-
[Scripting] What Am I Doing Wrong?
Hey there,
I want to add try and catch functions to several expressions. You know it’s painful to add them manually, so I decided to do that via scripting.
var selComp = app.project.activeItem;
var numSelLay = selComp.selectedLayers.length;
var addExprBeg = "try { \r \r ";
var addExprEnd = ";\r \r} catch(err) { \r \r value; \r \r}";for (i = 1; i <= numSelLay; i++) {
var numSelProp = selComp.selectedLayers[i].selectedProperties.length;
for (x = 1; x <= numSelProp; x++) {
var Express = selComp.selectedLayers[i].selectedProperties[x].expression;
selComp.selectedLayers[i].selectedProperties[x].expression = addExprBeg + Express + addExprEnd;
}
}
I selected the layers and their properties that I wanted to add the try and catch functions to, and ran this code. It added the try and catch functions to the properties of the selected layer #2 only and didn’t touch the rest of the selected layers. What did I do wrong?
If you have another way to do what I’m looking for, feel free to post it. I’m open-minded about new ways of doing things.
Thanks!
-
3 Replies
-
I see a couple of things. Your array indexing (for selected layers and properties) should start a 0, not 1 (and end with <, not <=). Also, (I’m guessing) changing an expression probably changes what’s selected, so you will probably end up having to fist save all the selected properties into an array, and then process the array.
Dan
-
Short answer: selectedLayers and selectedProperties are arrays , that means that the first element is 0, not 1, is not the same when you are selecting layers through the layerCollection object: layer(1). So you must change your for loops consecuently:
for (var i = 0; i < numSelLay; i++) {
...
for (var x = 0; x < numSelProp; x++) {
...
}
}
-
YAY! Thanks a lot Dan and Miguel! Dunno how I forgot such a fundamental rule of coding 🙂
Appreciate your time guys!
Reply to this Discussion! Login or Sign Up