Change dot to comma in expression

[Dan Ebberts]

I haven’t test this, but it should be close:

function Comma(number,sep) {
  number = " + Math.round(number);
  if (number.length > 3) {
    var mod = number.length % 3;
    var output = (mod > 0 ? (number.substring(0,mod)) : ");
    for (i=0 ; i < Math.floor(number.length / 3); i++) {
      if ((mod == 0) && (i == 0))
        output += number.substring(mod+ 3 * i, mod + 3 * i + 3);
      else
        output+= sep + number.substring(mod + 3 * i, mod + 3 * i + 3);
    }
    return (output);
  }
  else return number;
}
var num = Math.floor(effect("Number")("Valor").value);
var menu = effect("Number")("Dot and Comma").value;
var mySep = menu == 3 || menu == 4 ? "," : ".";
num = Comma(num,mySep);

[Otávio Nascimento]

Error on line 2: Undetermined string constant

[Dan Ebberts]

Sorry. Line 2 should probably be like this:

number = '' + Math.round(number);

There may be others that I didn’t catch from when you posted your original expression without using the </> formatting.

[Dan Ebberts]

There’s another one in there. I still haven’t been able to completely test this because of your effect names, but I can test everything but those two lines and I think this works now:

function Comma(number,sep) {
  number = '' + Math.round(number);
  if (number.length > 3) {
    var mod = number.length % 3;
    var output = (mod > 0 ? (number.substring(0,mod)) : '');
    for (i=0 ; i < Math.floor(number.length / 3); i++) {
      if ((mod == 0) && (i == 0))
        output += number.substring(mod+ 3 * i, mod + 3 * i + 3);
      else
        output+= sep + number.substring(mod + 3 * i, mod + 3 * i + 3);
    }
    return (output);
  }
  else return number;
}
var num = Math.floor(effect("Number")("Valor").value);
var menu = effect("Number")("Dot and Comma").value;
var mySep = menu == 3 || menu == 4 ? "," : ".";
num = Comma(num,mySep);

[Otávio Nascimento]

It worked! Thank you for letting me know about this </> format.

One more thing that I didnt mention I want to add is:

If the dropdown menu value is 5 change to “_”: 1_000

If the dropdown menu value is 6 change to ” “: 1 000

How the expression looks like?

You can test with this:

var num = Math.floor(effect("Slider Control")("Slider").value);
var menu = effect("Dropdown Menu Control")("Menu").value;
var mySep = menu == 3 || menu == 4 ? "," : ".";
num = Comma(num,mySep);

[Dan Ebberts]

I think I’d do it this way:

function Comma(number,sep) {
  number = '' + Math.round(number);
  if (number.length > 3) {
    var mod = number.length % 3;
    var output = (mod > 0 ? (number.substring(0,mod)) : '');
    for (i=0 ; i < Math.floor(number.length / 3); i++) {
      if ((mod == 0) && (i == 0))
        output += number.substring(mod+ 3 * i, mod + 3 * i + 3);
      else
        output+= sep + number.substring(mod + 3 * i, mod + 3 * i + 3);
    }
    return (output);
  }
  else return number;
}
var num = Math.floor(effect("Number")("Valor").value);
var menu = effect("Number")("Dot and Comma").value;
switch (menu){
  case 3:
  case 4:
    var mySep = ",";
    break;
  case 5:
    var mySep = "_";
    break;
  case 6:
    var mySep = " ";
    break;
  default:
    mySep = "."
    break;
}
num = Comma(num,mySep);

[Otávio Nascimento]

Thank you!

[Filip Vandueren]

I would do it compactly like this, letting Javascript do the number parsing/formatting

myNumber = Math.floor(1234567890.835);
mySeparator = "_";
new Intl.NumberFormat('en-US').formatToParts(myNumber).reduce((r,e) => r+(e.value=="," ? mySeparator : e.value), '');

[Otávio Nascimento]

That’s great! Thank you.