When you upgrade, also make sure you upgrade to the latest version of Apple Pro Video Formats. Starting with Mojave this is done from System Preferences>Software Update.
At any time you can check what version you are running by doing About This Mac>System Report>Installations, then scrolling down to Pro Video Formats.
As always, make sure you have good backups before upgrading.
Mojave will sometimes display a 32-bit incompatibility warning for various software. This is advisory only, it doesn’t cause any problems. This is to remind people the macOS version after Mojave will not support 32-bit apps or codecs.
Separately, FCPX 10.4.6 will indicate if any video files are encoded with a 32-bit codec that won’t be supported in future versions. It will also give the option of transcoding those to a supported format.
None of this is related to your problem but you might see this after upgrading.